More wrong doing what works ?? was(Re: About 7051 and Multilingual-TextConversion)

Yoshiki Ohshima yoshiki at squeakland.org
Fri Aug 11 05:08:34 UTC 2006


  Edgar,

> contentsOfEntireFile
>     "Read all of the contents of the receiver."
> 
>     | s binary |
>     self readOnly.
>     binary := self isBinary.
>     self converter: Latin1TextConverter new. "MY CHANGE WORKS"
>     self reset.    "erases knowledge of whether it is binary"
>     binary ifTrue: [self binary].
>     s := self next: self size.
>     self close.
>     ^s

  This method is used by many others, including the ones that assumes
text.  The client/user of streams has to aware that what it actually
wants to read.  In this case, probably fixing
SampledSound>>fromWaveStream: is the right thing to do.

-- Yoshiki



More information about the Squeak-dev mailing list