[ANN] WideString findSubstring patch attempt
nicolas cellier
ncellier at ifrance.com
Sat Jul 28 21:43:22 UTC 2007
nicolas cellier a écrit :
>
> Hi Edgar,
> It seems you have been confused by the names...
>
> #testSubstrings was designed for another bug, substrings.
> As indicated in comment it is related to
> http://bugs.squeak.org/view.php?id=6367
>
> It seems you have loaded my test but not my patch.
> So it leads to a failure in 3.10 7137.
>
> Note that Andreas provided an alternate solution later at
> http://bugs.squeak.org/view.php?id=6573
>
> I tried to open a discussion about respective interest of both
> solutions, but Andreas seems too busy.
>
> So, up to you to check and choose one...
>
> --------------------------------
>
> Concerning http://bugs.squeak.org/view.php?id=6366, i loaded the test
> (#testFindSubstring) then the patch in 3.10 7137, and the WideString
> tests pass.
>
> Nicolas
>
Edgar,
To follow up, I re-checked the tests provided by johnmci at
http://bugs.squeak.org/view.php?id=5331
Though they are not complete (these WideString involve only characters
with charCode<256..), they are stressing latest 3.10.
However, all proposed WideString-*-Test.*.cs pass if you apply following
patches:
http://bugs.squeak.org/view.php?id=5331 beginsWithWideStringPatch.1.cs
http://bugs.squeak.org/view.php?id=6367 WideString-substrings-Test.1.cs
http://bugs.squeak.org/view.php?id=6366
Collection-WideString-findSubstring-Patch.1.cs
http://bugs.squeak.org/view.php?id=3574
Collection-String-IndexOf-Patch.3.cs
Last one is already in 3.10 7137
cheers
Nicolas
More information about the Squeak-dev
mailing list
|