[squeak-dev] Re: SystemEditor
Andreas Raab
andreas.raab at gmx.de
Wed Nov 26 22:53:17 UTC 2008
Hi Colin -
I was looking over SystemEditor and one thing that really surprised me
was the use of ClassEditors as proxies. What is the reasoning behind it?
It makes the design difficult to understand and extremely hard to debug
- I gave up trying to find out what causes the issue with class
migration when I effectively couldn't debug the editors since all they
would show me were those pretend-classes. Is there some sort of debug
mode to turn off all that evil magic? ;-)
Cheers,
- Andreas
Colin Putney wrote:
>
> On 25-Nov-08, at 11:21 PM, Andreas Raab wrote:
>
>> Holy cow. If that actually works, it's impressive as hell. Given the
>> complexity in ClassBuilder (all of which is the direct result of
>> people actually using it and running into issues) it'll be no small
>> feat to get this right in SystemEditor. I've spent a few years on it ;-)
>
> It shows. ClassBuilder isn't actually that hard to understand. The
> constraints are hairy, but the code is fairly straightforward and has
> lots of comments.
>
> In SystemEditor, those constraints are encapsulated in ClassFormat, with
> unit tests. The tests probably aren't as complete as they could be, but
> it gives us a place to document issues as they come up.
>
> I'm looking forward to reenabling atomic commits in Monticello2. The
> speed improvement there is even greater, because right now, MC2 takes a
> speed hit from loading instance variables one at a time.
>
> Colin
>
>
More information about the Squeak-dev
mailing list
|