[squeak-dev] The Trunk: Collections-ul.228.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Dec 1 04:47:17 UTC 2009


Andreas Raab uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-ul.228.mcz

==================== Summary ====================

Name: Collections-ul.228
Author: ul
Time: 1 December 2009, 4:28:09 am
UUID: f703f0eb-7da9-a44e-b2c4-ec682d060db8
Ancestors: Collections-ul.217

Part 1 of IdentityDictionary hash change.
Also removed previous postscript.

=============== Diff against Collections-ul.217 ===============

Item was changed:
  ----- Method: IdentityDictionary>>scanFor: (in category 'private') -----
  scanFor: anObject
  	"Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements."
  
+ 	| index start |
+ 	CollectionRehashingUtility quickRehashBecause: #identityDictionaryScanForChanged.
+ 	index := start := anObject scaledIdentityHash \\ array size + 1.
- 	| index start hash |
- 	array size >= 8192
- 		ifTrue: [ hash := anObject identityHash * (array size // 4096) ]
- 		ifFalse: [ hash := anObject identityHash ].
- 	index := start := hash \\ array size + 1.
  	[ 
  		| element |
  		((element := array at: index) == nil or: [ element key == anObject ])
  			ifTrue: [ ^index ].
  		(index := index \\ array size + 1) = start ] whileFalse.
  	self errorNoFreeSpace!

Item was changed:
  ----- Method: IdentityDictionary>>scanForEmptySlotFor: (in category 'private') -----
  scanForEmptySlotFor: anObject
  	"Scan the key array for the first slot containing an empty slot (indicated by a nil). Answer the index of that slot. This method will be overridden in various subclasses that have different interpretations for matching elements."
  	
+ 	| index start |
+ 	index := start := anObject scaledIdentityHash \\ array size + 1.
- 	| index start hash |
- 	array size >= 8192
- 		ifTrue: [ hash := anObject identityHash * (array size // 4096) ]
- 		ifFalse: [ hash := anObject identityHash ].
- 	index := start := hash \\ array size + 1.
  	[ 
  		(array at: index) ifNil: [ ^index ].
  		(index := index \\ array size + 1) = start ] whileFalse.
  	self errorNoFreeSpace!

Item was changed:




More information about the Squeak-dev mailing list