[squeak-dev] Re: SystemWindow titlebar buttons.

Andreas Raab andreas.raab at gmx.de
Mon Dec 14 01:14:24 UTC 2009


Ronald Spengler wrote:
> Why use ScriptingSystem for this? Seems unnecessary. If there's a good
> reason to, why not use it for both?

There's no good reason. These forms were stored there initially and when 
someone wanted to use them in SystemWindow they naturally used the 
ScriptingSystem formAtKey: pattern.

This should probably be migrated to something more along the lines of 
MenuIcons (perhaps call it StandardGraphics), i.e., a utility class 
whose only purpose is to store some of the graphic resources that are 
widely used throughout the system. Then have ScriptingSystem delegate to it.

If you're looking for a short-term fix, just move it into another class 
var in SystemWindow. That's a recognizable pattern too.

Cheers,
   - Andreas




More information about the Squeak-dev mailing list