[squeak-dev] The Trunk: Files-dtl.61.mcz

David T. Lewis lewis at mail.msen.com
Sat Dec 26 19:37:48 UTC 2009


On Sat, Dec 26, 2009 at 05:49:48AM +0100, Levente Uzonyi wrote:
> On Fri, 25 Dec 2009, David T. Lewis wrote:
> 
> >I ran into problems saving the large changes file patches, and reverted
> >the update.  Sorry for the noise.
> >
> 
> I guess the problem is related to #fileIndexFromSourcePointer: which 
> returns 0 if sent to a StandardSourceFileArray when the argument is less 
> than 16777216 (16r1000000), while ExpandedSourceFileArray returns 2. I 
> guess that 0 is a valid result and some code expects this value.
> 
> Another difference between the two implementations is that 
> ExpandedSourceFileArray new filePositionFromSourcePointer: 0 ===> -16777216
> while
> StandardSourceFileArray new filePositionFromSourcePointer: 0 ===> 0

Thank you, you're right. I'll fix this and spend some more time testing.

Dave

> 
> >On a positive note, I have a changes file that has reached 426 MB without
> >problems, so the updated sourcePointer address mapping works fine.
> 
> Great. :)
> 



More information about the Squeak-dev mailing list