[squeak-dev] Re: New TextDiffBuilder implementation
Andreas Raab
andreas.raab at gmx.de
Tue Dec 29 13:11:56 UTC 2009
Levente Uzonyi wrote:
> Hi,
>
> We rewrote TextDiffBuilder using a modified version of the greedy
> longest common subsequence algorithm from 'An O(ND) Difference Algorithm
> and Its Variations (1986)' by Eugene W. Myers [1]. It's in The Inbox as:
>
> System-klub.209. The implementation is smaller, faster, gives a minimal
> patch and passes the tests.
>
> Old New Ratio
> Number of classes 5 4 0.8
> Number of methods 50 29 0.58
> Lines of code 387 197 0.51
>
> We would appreciate if someone can review this before moving into trunk.
Looks good. There seem to be a few matches that are shown differently
(tried with various MC diffs) but that's to be expected since it's a
different algorithm. Ship it :-)
Cheers,
- Andreas
More information about the Squeak-dev
mailing list
|