[squeak-dev] Re: [Vm-dev] New Window VM (Closures, FT2Plugin, Large Cursors)

Eliot Miranda eliot.miranda at gmail.com
Tue Mar 10 00:16:53 UTC 2009


On Mon, Mar 9, 2009 at 4:06 PM, Keith Hodges <keith_hodges at yahoo.co.uk>wrote:

> Keith Hodges wrote:
> > Keith Hodges wrote:
> >
> >> Keith Hodges wrote:
> >>
> >>
> >>>> I will at some point push out a 3.8.22 VM that should put up a more
> >>>> helpful dialog message, but people who have older VMs underfoot
> >>>> should realize this behaviour should be an indication that perhaps
> >>>> your VM is too old.
> >>>>
> >>>>
> >>>>
> >>> Unfortunately the machine that I have designated for Bob to be an auto
> >>> build/test server is a power-pc machine. What are the chances of a
> >>> power-pc version of the closures vm?
> >>>
> >>> just interested to know
> >>>
> >>> Keith
> >>>
> >>>
> >> Ok I see it is designated beta1U for universal, so the problem lies
> >> elsewhere!
> >>
> >> Keith
> >>
> >>
> > OK so assigining to closure temporaries is no-longer allowed and flags a
> > syntax error (not my code you understand)
> >
> > Keith
> >
> Does this mean that existing compiled code is expected to work, but an
> image recompile could cause problems?


Depends on how you set the allowBlockArgumentAssignment preference.

I have just fixed an instance in MCzInstaller>>#associate: Which assigns
> to the block temporary.
>
> associate: tokens
>    | result |
>    result _ Dictionary new.
>    tokens pairsDo: [:key :value |
>                    value isString ifFalse: [value _ value collect: [:ea
> | self associate: ea]].
>                    value = 'nil' ifTrue: [value _ ''].
>                    result at: key put: value].
>    ^ result
>
> The fix is so ugly that I am beginning to think that assigning to a
> block temp isn't such a bad idea after all.


If I could figure out what the domain and co-domain of tokens were I might
be able to avoid that horrible value = 'nil' ifTrue: [value _ ''] phrase :)

>
>
> Keith
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20090309/84227569/attachment.htm


More information about the Squeak-dev mailing list