[squeak-dev] The Trunk: ST80-dtl.62.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Nov 1 02:45:16 UTC 2009


David T. Lewis uploaded a new version of ST80 to project The Trunk:
http://source.squeak.org/trunk/ST80-dtl.62.mcz

==================== Summary ====================

Name: ST80-dtl.62
Author: dtl
Time: 31 October 2009, 10:43:54 am
UUID: 580d55e7-ffc5-48ff-9294-eb73be6d861b
Ancestors: ST80-dtl.61

Fix ScreenController>>openMenu which had menu separator lines in the wrong position, and which opened a Morphic project in response to "open... ->mvc project". This change restores the original menu structure, except that "open... ->morphic project" and "open... ->morphic world" are now displayed only if Morphic is present in the image, as per presumed intent of the prior change to #openMenu.

Open concerns: The "open... -> keep this menu up" option, restored to the menu by this change, and "open... ->mvc project" options, which now attempts to open an mvc (not morphic) project, are both badly broken and will cause image freeze. The "open... ->file list" and "open... ->morphic world" selections (not related to this menu change) are also broken, probably for the same reason.

=============== Diff against ST80-dtl.61 ===============

Item was added:
+ ----- Method: ScreenController>>openMenuWithMorphicOptions (in category 'nested menus') -----
+ openMenuWithMorphicOptions
+ 	"Include 'morphic world' and 'morphic project' selections"
+ 	^ SelectionMenu labelList:
+ 		#(	'keep this menu up'
+ 
+ 			'browser'
+ 			'package browser'
+ 			'method finder'
+ 			'workspace'
+ 			'file list'
+ 			'file...'
+ 			'transcript'
+ 			'morphic world'
+ 
+ 			'simple change sorter'
+ 			'dual change sorter'
+ 
+ 			'mvc project'
+ 			'morphic project'
+ 			)
+ 		lines: #(1 9 11)
+ 		selections: #(durableOpenMenu
+ openBrowser openPackageBrowser openSelectorBrowser openWorkspace openFileList openFile openTranscript openMorphicWorld
+ openSimpleChangeSorter openChangeManager
+ openProject  openMorphicProject  )
+ "
+ ScreenController  new openMenuWithMorphicOptions startUp
+ "!

Item was changed:
  ----- Method: ScreenController>>openMenu (in category 'nested menus') -----
  openMenu
+ 	"Smalltalk hasMorphic ifTrue: [^self openMenuWithMorphicOptions]."
  	^ SelectionMenu labelList:
+ 		#(	'keep this menu up'
- 		#(
  
  			'browser'
  			'package browser'
  			'method finder'
  			'workspace'
  			'file list'
  			'file...'
  			'transcript'
- 			'morphic world'
  
  			'simple change sorter'
  			'dual change sorter'
  
+ 			'new project'
- 			'mvc project'
  			)
+ 		lines: #(1 8 10)
+ 		selections: #(durableOpenMenu
- 		lines: #(1 9 11)
- 		selections: #(
  openBrowser openPackageBrowser openSelectorBrowser openWorkspace openFileList openFile openTranscript
  openSimpleChangeSorter openChangeManager
+ openProject   )
- openProject  openMorphicProject  )
  "
  ScreenController  new openMenu startUp
  "!




More information about the Squeak-dev mailing list