[squeak-dev] Re: Splitting Set and Dictionary

Andreas Raab andreas.raab at gmx.de
Thu Nov 19 06:24:55 UTC 2009


Levente Uzonyi wrote:
> I uploaded 3 packages to the inbox which add a common superclass to Set 
> and Dictionary. The suggested load order is:
> 1. Collections-ul.198
> 2. Collections-ul.199
> 3. KernelTests-ul.110

Very nice, very nice. The tests pass too which leaves me with one 
nitpick only: Can I have a class comment for HashedCollection please? 
Pretty please? :-)

Cheers,
   - Andreas

> 
> Loading the packages will change previous behavior in some cases:
> 
> - Dictionary >> #copyWithout: doesn't raise an error anymore. Example:
>   (Dictionary newFrom: { #foo -> 1. #bar -> 2 }) copyWithout: 1
>     ==> a Dictionary(#bar->2 ) (instead of an error)
> - No more asymmetric set-dictionary equality. Example:
>   #(1 2) asSet = (Dictionary newFrom: { #foo -> 1. #bar -> 2 })
>     ==> false (instead of true)
>   (Dictionary newFrom: { #foo -> 1. #bar -> 2 }) = #(1 2) asSet
>     ==> false (same as before)
> 
> Cheers,
> Levente
> 
> 




More information about the Squeak-dev mailing list