[squeak-dev] The Trunk: ST80-mha.57.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Oct 12 08:22:25 UTC 2009


Michael Haupt uploaded a new version of ST80 to project The Trunk:
http://source.squeak.org/trunk/ST80-mha.57.mcz

==================== Summary ====================

Name: ST80-mha.57
Author: mha
Time: 12 October 2009, 10:22:26 am
UUID: 5c0482ec-8a2b-4eb9-b0d2-f586be85fe44
Ancestors: ST80-ar.56

made TestIndenting pass

both of the solutions described below are probably controversial

* the default font is different from what the tests expect in more recent trunk images; the test setup was changed to adhere to the test's expectations (might be more appropriate to instead have the test adhere to the system defaults)

* composition rectangle was changed in wrapping test to make text wrap in expected position (might be a problem in wrapping logic instead)

=============== Diff against ST80-ar.56 ===============

Item was changed:
  ----- Method: TestIndenting>>setUp (in category 'running') -----
  setUp
+ 	| text style |
- 	| text |
  	text := 'p	' asText, (Text string: 'word word' attribute: (TextIndent tabs: 1)).
+ 	style := (TextStyle named: #Accuny) copy.
+ 	style defaultFontIndex: 2. "Default to Accuny12 as expected by tests."
+ 	para := text asParagraph textStyle: style!
- 	para := text asParagraph!

Item was changed:
  ----- Method: TestIndenting>>testNewLineStartsIndentedWhenWrapped (in category 'testing') -----
  testNewLineStartsIndentedWhenWrapped
  	"Checks whether the beginning of a new line starts at the indented position"
  	| cb |
+ 	para compositionRectangle: (0 at 0 extent: para width - 24 at 100); updateCompositionHeight.
- 	para compositionRectangle: (0 at 0 extent: para width - 20 at 100); updateCompositionHeight.
  	para clippingRectangle: (0 at 0 extent: 200 at 200).
  	cb := para characterBlockForIndex: 8.
  	self assert: cb top > 0.
  	self assert: cb left = 24!




More information about the Squeak-dev mailing list