[squeak-dev] The Trunk: Collections-nice.126.mcz

Igor Stasenko siguctua at gmail.com
Sun Sep 6 19:23:05 UTC 2009


2009/9/6 David T. Lewis <lewis at mail.msen.com>:
> Related to this, SortedCollection class>>new: does nothing but call super new:
> and can safely be removed. But it does have a comment that serves to document
> the default sort block behavior, so leave it in the image?
>
Could be moved into the class comment?

> Dave
>
> On Sat, Sep 05, 2009 at 08:21:57PM +0000, commits at source.squeak.org wrote:
>> Nicolas Cellier uploaded a new version of Collections to project The Trunk:
>> http://source.squeak.org/trunk/Collections-nice.126.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Collections-nice.126
>> Author: nice
>> Time: 5 September 2009, 10:21:20 am
>> UUID: 32bbec9c-28ef-4c94-bd03-b84942671351
>> Ancestors: Collections-ar.125
>>
>> Avoid invoking super when self would do the job.
>> ( super basicNew issue http://bugs.squeak.org/view.php?id=6977 )
>>
>> =============== Diff against Collections-ar.125 ===============
>>
>> Item was changed:
>>   ----- Method: OrderedCollection class>>new: (in category 'instance creation') -----
>>   new: anInteger
>> +     ^ self basicNew setCollection: (Array new: anInteger)!
>> -     ^ super basicNew setCollection: (Array new: anInteger)!
>>
>> Item was changed:
>>   ----- Method: OrderedCollection class>>new:withAll: (in category 'instance creation') -----
>>   new: anInteger withAll: anObject
>> +     ^ self basicNew setContents: (Array new: anInteger withAll: anObject)!
>> -     ^ super basicNew setContents: (Array new: anInteger withAll: anObject)!
>>
>> Item was changed:
>>   ----- Method: Set class>>new: (in category 'instance creation') -----
>>   new: nElements
>>       "Create a Set large enough to hold nElements without growing"
>> +     ^ self basicNew initialize: (self sizeFor: nElements)!
>> -     ^ super basicNew initialize: (self sizeFor: nElements)!
>>
>
>



-- 
Best regards,
Igor Stasenko AKA sig.



More information about the Squeak-dev mailing list