On Mon, 5 Apr 2010, Chris Muller wrote:

> I don't think this has any bearing on focus..  Can you give me
> detailed steps to demonstrate the difference with the Beep vs. Echo
> back?

It was unrelated to your change, sorry. #crAction lost the keyboard focus.


Levente

>
>
> On Mon, Apr 5, 2010 at 8:58 AM, Levente Uzonyi <leves at elte.hu> wrote:
>> On Sat, 3 Apr 2010, commits at source.squeak.org wrote:
>>
>>> Chris Muller uploaded a new version of Morphic to project The Trunk:
>>> http://source.squeak.org/trunk/Morphic-cmm.407.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Morphic-cmm.407
>>> Author: cmm
>>> Time: 3 April 2010, 6:14:18.484 pm
>>> UUID: ee3a09dc-6bbc-48f9-b99c-2a05d2c5e056
>>> Ancestors: Morphic-ul.406
>>>
>>> The Searchbar now employs a more subdued "Echo back"
>>> (http://c2.com/ppr/checks.html#4) rather than beeping at the user.
>>
>> The only problem is that the Search Bar now loses the keyboard focus if no
>> match is found, which is pretty annoying.
>>
>>
>> Levente
>>
>>>
>>> =============== Diff against Morphic-ul.406 ===============
>>>
>>> Item was changed:
>>>  ----- Method: SearchBarMorph>>smartSearch (in category 'search') -----
>>>  smartSearch
>>>        "Take the user input and perform an appropriate search"
>>> +       | input newContents |
>>> -       | input |
>>>        input := self contents asString ifEmpty:[^self].
>>>        (Smalltalk bindingOf: input) ifNotNil:[:assoc| | global |
>>>                "It's a global or a class"
>>>                global := assoc value.
>>>                ^ToolSet browse: (global isBehavior ifTrue:[global]
>>> ifFalse:[global class]) selector: nil.
>>>        ].
>>>        (SystemNavigation new allImplementorsOf: input asSymbol)
>>> ifNotEmpty:[:list|
>>>                ^SystemNavigation new
>>>                        browseMessageList: list
>>>                        name: 'Implementors of ' , input
>>>        ].
>>>        input first isUppercase ifTrue:[
>>>                (Utilities classFromPattern: input withCaption: '')
>>> ifNotNil:[:aClass|
>>>                        ^ToolSet browse: aClass selector: nil.
>>>                ].
>>>        ] ifFalse:[
>>>                ^ToolSet default browseMessageNames: input
>>>        ].
>>> +       newContents := input, ' -- not found.'.
>>> +       self
>>> +               newContents: newContents;
>>> +               selectFrom: input size+1 to: newContents size!
>>> -       "Not found"
>>> -       Beeper beepPrimitive.!
>>>
>>>
>>>
>>
>>
>
>