[squeak-dev] Color fromString: broken
Bert Freudenberg
bert at freudenbergs.de
Thu Dec 9 00:12:00 UTC 2010
On 08.12.2010, at 15:36, Levente Uzonyi wrote:
> On Wed, 8 Dec 2010, Bert Freudenberg wrote:
>
>> Test case:
>>
>> Color fromString: 'yellow'
>>
>> used to return yellow. Now it returns a very dark gray.
>>
>> The culprit is in #asNumber:
>>
>> '16rYE' asNumber
>>
>> used to raise an error. Now it silently returns 16.
>
> It returns 0 since Squeak 3.9.
No, it returns 16 now. It ignores everything after the "6".
> Relying on such an error is bad idea and fixing this method is easy.
Agreed.
> Though it may have been hard to track the problem down.
Not *that* hard, fortunately ;)
> I wonder why is ColorNames an OrderedCollection instead of an IdentitySet.
No idea. Historical I guess.
- Bert -
> Levente
>
>>
>> I can't imagine why this would be desirable?
>>
>> - Bert -
>>
>>
>>
>>
>
More information about the Squeak-dev
mailing list
|