On 16.12.2010, at 02:19, commits at source.squeak.org wrote:

> Matthew Fulmer uploaded a new version of Kernel to project The Inbox:
> http://source.squeak.org/inbox/Kernel-mtf.528.mcz
> 
> ==================== Summary ====================
> 
> Name: Kernel-mtf.528
> Author: mtf
> Time: 15 December 2010, 9:18:17.283 pm
> UUID: f111a9ad-3262-4a7f-98e8-1179c970d1cf
> Ancestors: Kernel-mtf.526
> 
> Make the mouse button mappings be consistent across platforms, in the presence of the inconsistent Win32 VM
> 
> =============== Diff against Kernel-mtf.526 ===============
> 
> Item was changed:
>  ----- Method: InputSensor class>>installMouseDecodeTable (in category 'class initialization') -----
>  installMouseDecodeTable
>  	"Create a decode table that swaps the lowest-order 2 bits if 
> + 	Preferences swapMouseButtons is set.
> + 	
> + 	Also swap if the platform is windows, for consistency with the
> + 	other platform VMs"
> + 	ButtonDecodeTable :=
> + 		(Preferences swapMouseButtons
> + 			xor: Smalltalk platformName = 'Win32')
> - 	Preferences swapMouseButtons is set"
> - 	ButtonDecodeTable := Preferences swapMouseButtons
>  				ifTrue: [ByteArray withAll:
>  							((0 to: 255) collect: [:ea |
>  								((ea bitAnd: 1) << 1
>  									bitOr: (ea bitAnd: 2) >> 1)
>  										bitOr: (ea bitAnd: 16rFC) ])]
>  				ifFalse: [ByteArray
>  						withAll: (0 to: 255)]!
> 
> 

I don't think that's a good idea. How would you know which button mapping the user chose in his Windows VM settings? This just makes everything more complicated rather than less.

- Bert -