[squeak-dev] MNU sendsToSuper in inheritanceButtonColor

K. K. Subramaniam subbukk at gmail.com
Sat Jan 9 05:10:09 UTC 2010


Hi,

I got a MNU: sendsToSuper in CodeHolder>>inheritanceButtonColor while browsing 
methods (log attached).

currentCompiledMethod was nil this method. The initial test reads:
  ((currentCompiledMethod isKindOf: CompiledMethod) and: [Preferences 
decorateBrowserButtons]) ifFalse: [ ^Color transparent ].

I presume currentCompiledMethod can be nil when this method is called. So I 
changed the test to:
   	(Preferences decorateBrowserButtons
		or: [currentCompiledMethod isKindOf: CompiledMethod])
			ifFalse: [ ^ Color transparent ].
to make it more robust.

Is this the right fix? .. Subbu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SqueakDebug.log
Type: text/x-log
Size: 4377 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20100109/7f62d720/SqueakDebug.bin


More information about the Squeak-dev mailing list