[squeak-dev] Re: New trunk server
Levente Uzonyi
leves at elte.hu
Sun Jan 10 21:03:51 UTC 2010
On Sun, 10 Jan 2010, Andreas Raab wrote:
> Levente Uzonyi wrote:
>> It works, but there's a new (minor) issue: the diff contains double line
>> endings. And the old green image was better than the current blue on the
>> web interface, because other style elements are for the green image.
>
> Both should be fixed now.
There are (at least) three ways to fix the extra empty lines issue:
1. restore the original behavior in TextDiffBuilder >> #split: by using
endWithoutSeparators instead of end.
2. update TextDiffBuilder >> #printTextPatchSequence:on: to add cr if and
only if the line doesn't end with cr or crlf.
3. create a subclass of TextDiffBuilder that overrides #split: and throws
away line endings. and use that from MCDiffyTextWriter. The extension
methods could be moved there too.
Levente
>
> Cheers,
> - Andreas
>
>
More information about the Squeak-dev
mailing list
|