[squeak-dev] Re: New trunk server

Levente Uzonyi leves at elte.hu
Mon Jan 11 23:46:34 UTC 2010


On Mon, 11 Jan 2010, Nicolas Cellier wrote:

> Hi Levente,
> what about completely ignoring line endings in diffs ?
>

I intentionally added this feature. Do you think it's wrong?


Levente

> split: aString
> 	"I return an Array of strings which are the lines extracted from
> aString. All lines contain the line separator characters"
>
> 	^Array streamContents: [ :stream |
> 		aString lineIndicesDo: [ :start :endWithoutSeparators :end |
> 			stream nextPut: (aString copyFrom: start to: endWithoutSeparators) ] ]
>
> or simply
>
>
> split: aString
> 	"I return an Array of strings which are the lines extracted from
> aString. All lines contain the line separator characters"
>
> 	^Array streamContents: [ :stream |
> 		aString linesDo: [ :aLineWithoutEnding |
> 			stream nextPut: aLineWithoutEnding ] ]
>
> Nicolas
>
> 2010/1/11 Andreas Raab <andreas.raab at gmx.de>:
>> Levente Uzonyi wrote:
>>>
>>> On Sun, 10 Jan 2010, Andreas Raab wrote:
>>>>
>>>> I think I'll leave that decision to you, you seem to have a good handle
>>>> on this part of the system. FWIW, I had implemented option #2 for our
>>>> SqueakSource installation realizing that it would be robust even if we
>>>> decided to leave out the CRs from the diff.
>>>
>>> With the latest TextDiffBuilder changes everything should work fine with
>>> all versions of SqueakSource. #buildTextPatch is SqueakSource's extension
>>> method, changing that would break backwards compatibility.
>>
>> Yup, agreed. It was a quick localized fix for our installation. I didn't
>> feel like messing around with TextDiffBuilder itself - making the change in
>> the one extension method felt safer for our purposes. Thanks for fixing the
>> issue at the root!
>>
>> Cheers,
>>  - Andreas
>>
>>
>
>


More information about the Squeak-dev mailing list