[squeak-dev] The Trunk: Morphic-ar.444.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Jun 16 03:56:09 UTC 2010

Andreas Raab uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-ar.444
Author: ar
Time: 15 June 2010, 8:53:28.939 pm
UUID: d1a51233-342a-694b-9f11-09f9b3f7afe6
Ancestors: Morphic-cmm.443

Fix some clipping issues with PluggableTextMorph which handled resizing of its textMorph in the wrong place. This could cause the textMorph to have different extent than the scroller causing incorrect clipping under a variety of situation (amongst which was disabling alwaysShowVScrollBar).

=============== Diff against Morphic-cmm.443 ===============

Item was changed:
  ----- Method: PluggableTextMorph>>extent: (in category 'geometry') -----
  extent: newExtent
  	bounds extent = newExtent ifTrue: [^ self].
  	super extent: (newExtent max: 36 at 16).
- 	textMorph ifNotNil:
- 		[textMorph extent: (self innerBounds width-6)@self height].
  	self setScrollDeltas

Item was changed:
  ----- Method: PluggableTextMorph>>resetExtent (in category 'geometry') -----
  	"Reset the extent while maintaining the current selection.  Needed when resizing while the editor is active (when inside the pane)."
  	| tempSelection |
  	textMorph notNil ifTrue:
  		["the current selection gets munged by resetting the extent, so store it"
  		tempSelection := self selectionInterval.
  		"don't reset it if it's not active"
  		tempSelection = (Interval from: 1 to: 0) 
  						ifTrue: [retractableScrollBar
  							ifTrue:[ ^ self]].
  		self extent: self extent.
+ 		self setSelection: tempSelection].
+ 	super resetExtent.!
- 		self setSelection: tempSelection]!

Item was added:
+ ----- Method: PluggableTextMorph>>resizeScroller (in category 'geometry') -----
+ resizeScroller
+ 	"Also needs to resize the text morph"
+ 	super resizeScroller.
+ 	textMorph ifNotNil:
+ 		[textMorph extent: (self innerBounds width-6)@self height].
+ !

More information about the Squeak-dev mailing list