[squeak-dev] The Trunk: Compiler-ar.131.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Mar 5 07:45:32 UTC 2010


Andreas Raab uploaded a new version of Compiler to project The Trunk:
http://source.squeak.org/trunk/Compiler-ar.131.mcz

==================== Summary ====================

Name: Compiler-ar.131
Author: ar
Time: 4 March 2010, 11:45:13.288 pm
UUID: 5a06205c-1edd-454e-97d5-e6db20aed3b1
Ancestors: Compiler-nice.130

Having removed the last uses of SyntaxError to indicate non-interactive compile, simplify Parser/Compiler>>interactive to just test for non-nil requestor.

=============== Diff against Compiler-nice.130 ===============

Item was changed:
  ----- Method: Encoder>>interactive (in category 'private') -----
  interactive
+ 	"Answer true if compilation is interactive"
+ 
  	^requestor interactive!

Item was changed:
  ----- Method: Parser>>interactive (in category 'error handling') -----
  interactive
+ 	"Answer true if compilation is interactive"
- 	"this version of the method is necessary to load code from MC else the interactive mode is one. 
- 	This method is really bad since it links the compiler package with the Tools
- 	one. The solution would be to have a real SyntaxError exception belonging to the 
- 	compiler package and not a subclass of StringHolder - sd Nov 2005"
- 	"the code submitted by PlusTools is ideally the one that should be used
- 	interactive
  
+ 	^requestor notNil!
- 	      ^requestor ~~ nil "
- 	
- 	^ (requestor == nil or: [requestor isKindOf: SyntaxError]) not!

Item was changed:
  ----- Method: Compiler>>interactive (in category 'private') -----
  interactive
+ 	"Answer true if compilation is interactive"
- 	"this version of the method is necessary to load code from MC else the interactive mode is one. 
- 	This method is really bad since it links the compiler package with the Tools
- 	one. The solution would be to have a real SyntaxError exception belonging to the 
- 	compiler package and not a subclass of StringHolder - sd Nov 2005"
- 	"the code submitted by PlusTools is ideally the one that should be used
- 	interactive
  
+ 	^requestor notNil!
- 	      ^requestor ~~ nil "
- 	
- 	^ (requestor == nil or: [requestor isKindOf: SyntaxError]) not!




More information about the Squeak-dev mailing list