[squeak-dev] Re: [Pkg] The Trunk: Tools-cmm.211.mcz

Bert Freudenberg bert at freudenbergs.de
Tue Mar 16 10:52:43 UTC 2010


On 16.03.2010, at 00:00, commits at source.squeak.org wrote:
> 
> Chris Muller uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-cmm.211.mcz
> 
> ==================== Summary ====================
> 
> Name: Tools-cmm.211
> Author: cmm
> Time: 15 March 2010, 7:00:07.585 pm
> UUID: 334c161d-c0de-4a09-8f96-c314747e9238
> Ancestors: Tools-nice.210
> 
> Integrated new ListChooser from Michael Davies.
> 
> =============== Diff against Tools-nice.210 ===============
> 
> Item was changed:
>  ----- Method: Browser>>findMethod (in category 'class functions') -----
>  findMethod
>  	"Pop up a list of the current class's methods, and select the one chosen by the user"
> - 
>  	| aClass selectors reply cat messageCatIndex messageIndex |
>  	self classListIndex = 0 ifTrue: [^ self].
>  	self okToChange ifFalse: [^ self].
>  	aClass := self selectedClassOrMetaClass.
>  	selectors := aClass selectors asSortedArray.
>  	selectors isEmpty ifTrue: [self inform: aClass name, ' has no methods.'. ^ self].
>  	reply := UIManager default 
> + 		chooseFrom: selectors
> + 		values: selectors
> - 		chooseFrom: (Array with: 'Enter Wildcard'), selectors
> - 		values: (Array with: 'Enter Wildcard'), selectors
>  		lines: #(1).
>  	reply == nil ifTrue: [^ self].
>  	reply = 'Enter Wildcard'
>  		ifTrue: [
>  			reply := UIManager default request: 'Enter partial method name:'.
>  			(reply isNil or: [reply isEmpty])
>  				ifTrue: [^self].
>  			(reply includes: $*)
>  				ifFalse: [reply := '*', reply, '*'].
>  			selectors := selectors select: [:each | reply match: each].
>  			selectors isEmpty ifTrue: [self inform: aClass name, ' has no matching methods.'. ^ self].
>  			reply := selectors size = 1
>  				ifTrue: [selectors first]
>  				ifFalse: [
>  					UIManager default
>  						chooseFrom: selectors
>  						values: selectors].
>  			reply == nil ifTrue: [^ self]].
> - 
>  	cat := aClass whichCategoryIncludesSelector: reply.
>  	messageCatIndex := self messageCategoryList indexOf: cat.
>  	self messageCategoryListIndex: messageCatIndex.
>  	messageIndex := (self messageList indexOf: reply).
>  	self messageListIndex: messageIndex!
> 

Is there a reason to leave the wildcard code in, since it seems to be inaccessible now?

- Bert -





More information about the Squeak-dev mailing list