On Tue, May 18, 2010 at 05:02:05PM -0700, Eliot Miranda wrote:
> Hi David,
> 
> On Tue, May 18, 2010 at 4:33 PM, David T. Lewis <lewis at mail.msen.com> wrote:
> >
> > I tried the Decompiler.1.cs patch in Squeak trunk, and it produces some
> > undesirable
> > side effects. Here is what I did:
> >
> > - saved a copy of changes file
> > - created a new method in a browser
> > - save and exit
> > - copy saved changes file back to changes file (to eliminate the source for
> > new method)
> > - restart image
> > - decompiled code in browser shows bug reported by Hans-Martin Mosner
> > - loaded Decompiler.1.cs
> > - decompiled code in browser produces a "Note:" dialog, and the following
> >  (garbage) in the codeholder window:
> >
> >    "ueak/Squeak3.10-dev/squeak.10.image"
> >
> 
> that's a different issue caused by your effectively truncating the changes
> file. What you've done is arrange that the method's source pointer points
> into the SNAPSHOT marker in the original changes file.  What you need to do
> is select decompile from the source button dropdown menu in the browser, not
> switch the changes file underneath the method and expect the system to
> automatically figure out that the source is corrupt and it should decompile.

Yes, I understand, I was intentionally truncating the changes file
to see what would happen. Prior to applying Decompiler.1.cs, the
browser would show the decompiled (but incorrect) source. After
applying Decompiler.1.cs, it showed corrupt source. But oops, that
was because I had caused things to be written to the changes file,
so of course it looked like garbage source.

Sorry for the noise.

Thanks,
Dave