[squeak-dev] Re: Scanner>>xUnderscore vs xUnderscoreForTokenization

Igor Stasenko siguctua at gmail.com
Fri May 21 06:58:07 UTC 2010


Here is a changeset with patch.

On 21 May 2010 09:53, Igor Stasenko <siguctua at gmail.com> wrote:
> But more appropriate fix, i think is to remove
>
> #initScannerForTokenization from
> #parseSelector:  and #parseParameterNames:
> methods, instead of changing it.
>
> Because it is used in #typedScanTokens: , where comment explicitly
> says following:
>        "Answer an Array that has been tokenized with literals mapped to literals,
>         special characters mapped to symbols and variable names and keywords
>         to strings. This methiod accepts _ (underscore) as an assignment token
>         irrespective of whether the system prefers := as the assignment token."
>
>
>
> On 21 May 2010 09:18, Igor Stasenko <siguctua at gmail.com> wrote:
>> Hello,
>>
>> it looks like xUnderscoreForTokenization is now redundant,
>> because xUnderscore does the right thing, depending on preferences you set,
>> while xUnderscoreForTokenization don't using a preferences and that's
>> why you'll get a warnings
>> when browsing a methods which having underscore in selectors.
>>
>> A proposed fix is to make
>> Scanner>>initScannerForTokenization be a no-op.
>>
>>
>> --
>> Best regards,
>> Igor Stasenko AKA sig.
>>
>
>
>
> --
> Best regards,
> Igor Stasenko AKA sig.
>



-- 
Best regards,
Igor Stasenko AKA sig.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: underscore-patterns-parsing.1.cs
Type: application/octet-stream
Size: 1340 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20100521/a407891c/underscore-patterns-parsing.1.obj


More information about the Squeak-dev mailing list