[squeak-dev] The Trunk: Tools-fbs.314.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Apr 20 23:08:05 UTC 2011


Levente Uzonyi uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.314.mcz

==================== Summary ====================

Name: Tools-fbs.314
Author: fbs
Time: 16 March 2011, 7:24:14.267 am
UUID: 10ebbe1f-66ea-914d-86b5-ea07496aa495
Ancestors: Tools-fbs.313

More classListIndex removals. Note that CodeHolder>>spawnHierarchy now returns the newly-created browser. This is so the relevant test can close the browser afterwards.

=============== Diff against Tools-fbs.313 ===============

Item was changed:
  ----- Method: CodeHolder>>spawnHierarchy (in category 'traits') -----
  spawnHierarchy
  	"Create and schedule a new hierarchy browser on the currently selected class or meta."
  
  	| newBrowser aSymbol aBehavior messageCatIndex selectedClassOrMetaClass |
  	(selectedClassOrMetaClass := self selectedClassOrMetaClass)
  		ifNil: [^ self].
  	selectedClassOrMetaClass isTrait ifTrue: [^self].
  	newBrowser := HierarchyBrowser new initHierarchyForClass: selectedClassOrMetaClass.
  	((aSymbol := self selectedMessageName) notNil and: [(MessageSet isPseudoSelector: aSymbol) not])
  		ifTrue:
  			[aBehavior := selectedClassOrMetaClass.
  			messageCatIndex := aBehavior organization numberOfCategoryOfElement: aSymbol.
  			newBrowser messageCategoryListIndex: messageCatIndex + 1.
  			newBrowser messageListIndex:
  				((aBehavior organization listAtCategoryNumber: messageCatIndex) indexOf: aSymbol)].
  	Browser
  		openBrowserView: (newBrowser openSystemCatEditString: nil)
  		label: newBrowser labelString.
  	Smalltalk isMorphic
  		ifTrue: ["this workaround only needed in morphic"
+ 			newBrowser assureSelectionsShow].
+ 	^ newBrowser.!
- 			newBrowser assureSelectionsShow]!

Item was changed:
  ----- Method: FileContentsBrowser>>changeMessageCategories: (in category 'other') -----
  changeMessageCategories: aString 
  	"The characters in aString represent an edited version of the the message 
  	categories for the selected class. Update this information in the system 
  	and inform any dependents that the categories have been changed. This 
  	message is invoked because the user had issued the categories command 
  	and edited the message categories. Then the user issued the accept 
  	command."
  
  	self classOrMetaClassOrganizer changeFromString: aString.
  	self unlock.
  	self editClass.
+ 	self selectClassNamed: selectedClassName.
- 	self classListIndex: classListIndex.
  	^ true!

Item was changed:
  ----- Method: HierarchyBrowser>>assureSelectionsShow (in category 'class list') -----
  assureSelectionsShow
  	"This is a workaround for the fact that a hierarchy browser, when launched, often does not show the selected class"
  
  	| saveCatIndex saveMsgIndex |
  	saveCatIndex := messageCategoryListIndex.
  	saveMsgIndex := messageListIndex.
+ 	self selectClassNamed: selectedClassName.
- 	self classListIndex: classListIndex.
  	self messageCategoryListIndex: saveCatIndex.
  	self messageListIndex: saveMsgIndex!




More information about the Squeak-dev mailing list