[squeak-dev] The Trunk: Tools-fbs.324.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Apr 20 23:15:20 UTC 2011


Levente Uzonyi uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.324.mcz

==================== Summary ====================

Name: Tools-fbs.324
Author: fbs
Time: 22 March 2011, 10:35:23.459 pm
UUID: 1552aa40-a991-754a-9b83-ed7683ce9d06
Ancestors: Tools-fbs.323

A bunch more messageListIndex reference removals. #messageListIndexOf: encapsulates messageList a bit more. This is necessary because while a Browser's messageList stores strings, a MessageSet's messageList stores MethodReferences.

=============== Diff against Tools-fbs.323 ===============

Item was added:
+ ----- Method: Browser>>messageListIndexOf: (in category 'message list') -----
+ messageListIndexOf: aString
+ 	^ self messageList indexOf: aString.!

Item was changed:
  ----- Method: Browser>>selectMessageNamed: (in category 'message list') -----
  selectMessageNamed: aSymbolOrString
  	| name |
  	name := aSymbolOrString ifNil: [ 0] ifNotNil: [ aSymbolOrString asSymbol ].
+ 	self messageListIndex: (self messageListIndexOf: name).!
- 	self messageListIndex: (self messageList indexOf: name).!

Item was added:
+ ----- Method: MessageSet>>messageListIndexOf: (in category 'message list') -----
+ messageListIndexOf: aString
+ 	^ (self messageList collect: [:each | each selector]) indexOf: aString.!

Item was changed:
  ----- Method: MessageSet>>removeMessageFromBrowser (in category 'message functions') -----
  removeMessageFromBrowser
  	"Remove the selected message from the browser."
  
+ 	self hasMessageSelected ifFalse: [^ self].
- 	messageListIndex = 0 ifTrue: [^ self].
  	self deleteFromMessageList: self selection.
  	self reformulateList.
  	self adjustWindowTitleAfterFiltering
  !

Item was changed:
  ----- Method: MessageSet>>selectedClassOrMetaClass (in category 'class list') -----
  selectedClassOrMetaClass
  	"Answer the currently selected class (or metaclass)."
+ 	self hasMessageSelected ifFalse: [^nil].
- 	messageListIndex = 0 ifTrue: [^nil].
  	self setClassAndSelectorIn: [:c :s | ^c]!

Item was changed:
  ----- Method: MessageSet>>selectedMessageCategoryName (in category 'class list') -----
  selectedMessageCategoryName 
  	"Answer the name of the selected message category or nil."
+ 	self hasMessageSelected ifFalse: [^ nil].
- 	messageListIndex = 0 ifTrue: [^ nil].
  	^ self selectedClassOrMetaClass organization categoryOfElement: self selectedMessageName!




More information about the Squeak-dev mailing list