[squeak-dev] The Trunk: ToolsTests-fbs.35.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Apr 20 23:28:27 UTC 2011


Levente Uzonyi uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-fbs.35.mcz

==================== Summary ====================

Name: ToolsTests-fbs.35
Author: fbs
Time: 29 March 2011, 5:00:25.456 pm
UUID: cc83cf8d-76ca-e44b-a255-6c3bb1cf7bc0
Ancestors: ToolsTests-fbs.34

#selectMessageNamed: and #selectedMessageName don't make much sense for MessageSets (which MethodReference did you mean to select when you were browsering all-implementors-of?) so let's avoid them in the tests.

=============== Diff against ToolsTests-fbs.33 ===============

Item was added:
+ ----- Method: MessageNamesTest>>testSelectedClassOrMetaClass (in category 'as yet unclassified') -----
+ testSelectedClassOrMetaClass
+ 	| firstClass |
+ 	browser searchString: 'cull'.
+ 	firstClass := browser messageList first actualClass.
+ 	
+ 	browser messageListIndex: 1.
+ 	self assert: browser selectedClassOrMetaClass = firstClass.
+ 	
+ 	browser messageListIndex: 0.
+ 	self assert: browser selectedClassOrMetaClass isNil.
+ 	
+ 	"And just to be sure:"
+ 	browser messageListIndex: 1.
+ 	self assert: browser selectedClassOrMetaClass = firstClass.!

Item was changed:
  ----- Method: MessageNamesTest>>testSelection (in category 'as yet unclassified') -----
  testSelection
  	browser searchString: 'cull'.
  	browser selectorListIndex: 1.
  	browser messageListIndex: 1.
  	self assert: (browser selection isKindOf: MethodReference).
  	browser messageListIndex: 0.
+ 	self assert: browser selection isNil.!
- 	self assert: browser selection isSymbol.!

Item was changed:
  ----- Method: MessageSetTest>>testContents (in category 'as yet unclassified') -----
  testContents
+ 	browser messageListIndex: 0.
- 	browser selectMessageNamed: nil.
  	self assert: browser contents = ''.
  	
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self deny: browser contents = ''.
  	!

Item was changed:
  ----- Method: MessageSetTest>>testHasMessageSelected (in category 'as yet unclassified') -----
  testHasMessageSelected
+ 	browser messageListIndex: 1.
- 	| firstSel |
- 	firstSel := browser messageList first selector.
- 	
- 	browser selectMessageNamed: firstSel.
  	self assert: browser hasMessageSelected.
  	
+ 	browser messageListIndex: 0.
- 	browser selectMessageNamed: nil.
  	self deny: browser hasMessageSelected.
  	
  	"And just to be sure:"
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: firstSel.
  	self assert: browser hasMessageSelected.!

Item was changed:
  ----- Method: MessageSetTest>>testRemoveMessageFromBrowser (in category 'as yet unclassified') -----
  testRemoveMessageFromBrowser
  	| count sel |
  	browser messageListIndex: 1.
  	sel := browser selection.
  	
  	browser removeMessageFromBrowser.
  	self deny: (browser messageList includes: sel) description: 'Method not removed'.
+ 
+ 	browser messageListIndex: 0.
- 	
- 	browser selectMessageNamed: nil.
  	count := browser messageList size.
  	browser removeMessageFromBrowser.
  	self assert: count = browser messageList size description: 'Some method was removed'.!

Item was changed:
  ----- Method: MessageSetTest>>testSelectedClassOrMetaClass (in category 'as yet unclassified') -----
  testSelectedClassOrMetaClass
  	| firstClass |
  	firstClass := browser messageList first actualClass.
  	
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self assert: browser selectedClassOrMetaClass = firstClass.
  	
+ 	browser messageListIndex: 0.
- 	browser selectMessageNamed: nil.
  	self assert: browser selectedClassOrMetaClass isNil.
  	
  	"And just to be sure:"
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self assert: browser selectedClassOrMetaClass = firstClass.!

Item was changed:
  ----- Method: MessageSetTest>>testSelectedMessageCategoryName (in category 'as yet unclassified') -----
  testSelectedMessageCategoryName
  	| firstCat methodRef |
  	methodRef := browser messageList first.
  	firstCat := methodRef actualClass organization categoryOfElement: methodRef selector.
  	
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self assert: browser selectedMessageCategoryName = firstCat.
  	
+ 	browser messageListIndex: 0.
- 	browser selectMessageNamed: nil.
  	self assert: browser selectedMessageCategoryName isNil.
  	
  	"And just to be sure:"
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self assert: browser selectedMessageCategoryName = firstCat.!

Item was changed:
  ----- Method: MessageSetTest>>testSelectedMessageName (in category 'as yet unclassified') -----
  testSelectedMessageName
  	| firstSel |
  	firstSel := browser messageList first selector.
  	
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: firstSel.
  	self assert: browser selectedMessageName = firstSel.
  	
+ 	browser messageListIndex: 0.
- 	browser selectMessageNamed: nil.
  	self assert: browser selectedMessageName isNil.
  	
  	"And just to be sure:"
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: firstSel.
  	self assert: browser selectedMessageName = firstSel.!

Item was changed:
  ----- Method: MessageSetTest>>testSelection (in category 'as yet unclassified') -----
  testSelection
  	| firstRef |
  	firstRef := browser messageList first.
  	
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self assert: browser selection = firstRef.
  	
+ 	browser messageListIndex: 0.
- 	browser selectMessageNamed: nil.
  	self assert: browser selection isNil.
  	
  	"And just to be sure:"
+ 	browser messageListIndex: 1.
- 	browser selectMessageNamed: browser messageList first selector.
  	self assert: browser selection = firstRef.!

Item was added:
+ MessageSetTest subclass: #MessageTraceTest
+ 	instanceVariableNames: ''
+ 	classVariableNames: ''
+ 	poolDictionaries: ''
+ 	category: 'ToolsTests-Browser'!

Item was added:
+ ----- Method: MessageTraceTest>>setUp (in category 'as yet unclassified') -----
+ setUp
+ 	browser := (MessageTrace
+ 		openMessageList: (SystemNavigation default allImplementorsOf: #browseAllImplementorsOf:)
+ 		name: 'Test MessageSet'
+ 		autoSelect: nil) model.!




More information about the Squeak-dev mailing list