[squeak-dev] The Trunk: ToolsTests-fbs.28.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Apr 20 23:28:38 UTC 2011


Levente Uzonyi uploaded a new version of ToolsTests to project The Trunk:
http://source.squeak.org/trunk/ToolsTests-fbs.28.mcz

==================== Summary ====================

Name: ToolsTests-fbs.28
Author: fbs
Time: 22 March 2011, 10:36:35.73 pm
UUID: 187b54df-2bfa-ab40-bd87-057cc5bdf0b4
Ancestors: ToolsTests-fbs.27

A bunch more messageListIndex reference removals. #messageListIndexOf: encapsulates messageList a bit more. This is necessary because while a Browser's messageList stores strings, a MessageSet's messageList stores MethodReferences.

=============== Diff against ToolsTests-fbs.26 ===============

Item was added:
+ ----- Method: MessageSetTest>>testHasMessageSelected (in category 'as yet unclassified') -----
+ testHasMessageSelected
+ 	| firstSel |
+ 	firstSel := browser messageList first selector.
+ 	
+ 	browser selectMessageNamed: firstSel.
+ 	self assert: browser hasMessageSelected.
+ 	
+ 	browser selectMessageNamed: nil.
+ 	self deny: browser hasMessageSelected.
+ 	
+ 	"And just to be sure:"
+ 	browser selectMessageNamed: firstSel.
+ 	self assert: browser hasMessageSelected.!

Item was changed:
  ----- Method: MessageSetTest>>testRemoveMessageFromBrowser (in category 'as yet unclassified') -----
  testRemoveMessageFromBrowser
+ 	| count sel |
- 	| sel |
  	browser messageListIndex: 1.
  	sel := browser selection.
  	
  	browser removeMessageFromBrowser.
+ 	self deny: (browser messageList includes: sel) description: 'Method not removed'.
+ 	
+ 	browser selectMessageNamed: nil.
+ 	count := browser messageList size.
+ 	browser removeMessageFromBrowser.
+ 	self assert: count = browser messageList size description: 'Some method was removed'.!
- 	self assert: (browser messageList includes: sel).!

Item was added:
+ ----- Method: MessageSetTest>>testSelectedClassOrMetaClass (in category 'as yet unclassified') -----
+ testSelectedClassOrMetaClass
+ 	| firstClass |
+ 	firstClass := browser messageList first actualClass.
+ 	
+ 	browser selectMessageNamed: browser messageList first selector.
+ 	self assert: browser selectedClassOrMetaClass = firstClass.
+ 	
+ 	browser selectMessageNamed: nil.
+ 	self assert: browser selectedClassOrMetaClass isNil.
+ 	
+ 	"And just to be sure:"
+ 	browser selectMessageNamed: browser messageList first selector.
+ 	self assert: browser selectedClassOrMetaClass = firstClass.!

Item was added:
+ ----- Method: MessageSetTest>>testSelectedMessageCategoryName (in category 'as yet unclassified') -----
+ testSelectedMessageCategoryName
+ 	| firstCat methodRef |
+ 	methodRef := browser messageList first.
+ 	firstCat := methodRef actualClass organization categoryOfElement: methodRef selector.
+ 	
+ 	browser selectMessageNamed: browser messageList first selector.
+ 	self assert: browser selectedMessageCategoryName = firstCat.
+ 	
+ 	browser selectMessageNamed: nil.
+ 	self assert: browser selectedMessageCategoryName isNil.
+ 	
+ 	"And just to be sure:"
+ 	browser selectMessageNamed: browser messageList first selector.
+ 	self assert: browser selectedMessageCategoryName = firstCat.!

Item was added:
+ ----- Method: MessageSetTest>>testSelectedMessageName (in category 'as yet unclassified') -----
+ testSelectedMessageName
+ 	| firstSel |
+ 	firstSel := browser messageList first selector.
+ 	
+ 	browser selectMessageNamed: firstSel.
+ 	self assert: browser selectedMessageName = firstSel.
+ 	
+ 	browser selectMessageNamed: nil.
+ 	self assert: browser selectedMessageName isNil.
+ 	
+ 	"And just to be sure:"
+ 	browser selectMessageNamed: firstSel.
+ 	self assert: browser selectedMessageName = firstSel.!

Item was added:
+ ----- Method: MessageSetTest>>testSelection (in category 'as yet unclassified') -----
+ testSelection
+ 	| firstRef |
+ 	firstRef := browser messageList first.
+ 	
+ 	browser selectMessageNamed: browser messageList first selector.
+ 	self assert: browser selection = firstRef.
+ 	
+ 	browser selectMessageNamed: nil.
+ 	self assert: browser selection isNil.
+ 	
+ 	"And just to be sure:"
+ 	browser selectMessageNamed: browser messageList first selector.
+ 	self assert: browser selection = firstRef.!




More information about the Squeak-dev mailing list