[squeak-dev] [Bug][Fix] In ReferenceStream, code review request

Levente Uzonyi leves at elte.hu
Thu Dec 8 11:04:25 UTC 2011


On Wed, 7 Dec 2011, David T. Lewis wrote:

> On Wed, Dec 07, 2011 at 10:04:46AM -0500, David T. Lewis wrote:
>> On Wed, Dec 07, 2011 at 02:06:09PM +0100, Levente Uzonyi wrote:
>>> On Tue, 6 Dec 2011, David T. Lewis wrote:
>>>>
>>>> I tried adding these changes and it looks like there are a few issues
>>>> still to be sorted out. I suspect we may want to just back these updates
>>>> out of trunk until after the Squeak 4.3 release is complete, then put
>>>> them back and finish any remaining work after the release is done.
>>>>
>>>> comments?
>>>
>>> I tried to fix it last night, but ImageSegment breaks the unwritten
>>> contract of ReferenceStream, so I'll probably just restore the previous
>>> behavior today and we'll fix this issue after the release of 4.3.
>>
>> Thanks Levente, I think that's the right thing to do.
>>
>
> I removed the first set of changes from trunk so as not to interfere with
> the 4.3 release process. Meanwhile we can post updates to inbox as needed.

I was only about to revert ReferenceStream >> #references to the previous 
version, but this is ok too.


Levente

>
> Dave
>
>
>



More information about the Squeak-dev mailing list