Moving LayoutFrame (was Re: [squeak-dev] [4.2] tests status)

Chris Muller asqueaker at gmail.com
Thu Jan 6 00:08:55 UTC 2011


I haven't looked at the "code" (oh wait, there shouldn't be any code
iwth this right?).

It sounds like the right thing to do.  Anyone else object?

On Wed, Jan 5, 2011 at 3:30 PM, Bernhard Pieber <bernhard at pieber.com> wrote:
> Dear core developers,
>
> Are there any objections to move this to the trunk?
>
> Cheers,
> Bernhard
>
> Am 01.01.2011 um 17:05 schrieb Bernhard Pieber:
>> Dear Squeakers,
>>
>> I went ahead with my proposal to move LayoutFrame from Morphic to Graphics and published new versions of both packages to the inbox. From the commit comment:
>>
>> - moved LayoutFrame from Morphic-Layout to Graphics-Primitives because it is not specific to Morphic, i.e. it has no references to it and is perfectly usable - and used - by MVC only UIs. This also fixes PackageDependencyTest>>#testSUnitGUI.
>>
>> Graphics-bp.173 should be loaded before Morphic-bp.505.
>>
>> I kindly ask you core developers to consider moving it to the trunk.
>>
>> Happy New Year!
>>
>> Bernhard
>>
>> Am 23.12.2010 um 19:37 schrieb Bernhard Pieber:
>>> I am afraid I broke #testSUnitGUI when I improved the resize behavior of the Test Runner. Therefore I want to fix it. I used LayoutFrame for this which currently is in Morphic. Therefore SUnitGUI suddenly depends on Morphic which it should not because it uses ToolBuilder.
>>>
>>> I think the right fix is to move LayoutFrame out of Morphic because it is not at all specific to Morphic. It is perfectly usable in MVCs UIs. And I guess it is also used there. The only question is where to move it? I think the best place would be the Graphics-Primitives class category in the Graphics package. This is where Point and Rectangle are. I tried it and it fixes the dependency test without breaking others. What do you think? I would like some feedback before I commit it to the inbox.
>
>
>



More information about the Squeak-dev mailing list