On Sun, 30 Jan 2011, commits at source.squeak.org wrote:

> Chris Muller uploaded a new version of ReleaseBuilder to project The Trunk:
> http://source.squeak.org/trunk/ReleaseBuilder-cmm.57.mcz

snip

>  ----- Method: ReleaseBuilderTrunk classSide>>prepareNewBuild (in category 'scripts') -----
> + prepareNewBuild
> + 	"ReleaseBuilderTrunk prepareNewBuild"
> - prepareNewBuild "ReleaseBuilderTrunk prepareNewBuild"
>  	"Prepare everything that should be done for a new image build"
>  	SystemVersion setVersion.
> + 	SMLoaderPlus
> + 		setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
> + 	self setDisplayExtent: 800 @ 600;
> + 		 setBackground;
> + 		 setPreferences;
> + 		 switchTo42Repository;
> + 		 openWelcomeWorkspace.
> - 	MCMcmUpdater defaultUpdateURL: 'http://source.squeak.org/squeak42'.
> - 	SMLoaderPlus setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
> - 	self
> - 		setDisplayExtent: 800 at 600 ;
> - 		setBackground ;
> - 		setPreferences.
>  	"Make DependencyBrowser accessible on the open menu."
>  	DependencyBrowser initialize.
>  	Smalltalk cleanUp: true.
>  	Undeclared removeUnreferencedKeys.
>  	Smalltalk garbageCollect.
> + 	3
> + 		timesRepeat: [Smalltalk garbageCollect.
> + 			Symbol compactSymbolTable]!

What's the point of doing this 3 times? Btw Symbol's #cleanUp already 
compacts the symbol table, so it's not 3, but 4 times.

IMHO a real improvement would be to change HashedCollection class >> 
#cleanUp: to send #compactAll instead of #rehashAll.

Also #compactSymbolTable starts with a full GC, so it's pointless to do it 
one more time in the loop.


Levente

snip