[squeak-dev] readFrom: vs readFromString:

David T. Lewis lewis at mail.msen.com
Sun Oct 30 20:43:28 UTC 2011


On Sun, Oct 30, 2011 at 05:07:48PM +0100, Nicolas Cellier wrote:
> There is a huge mess in #readFrom: implementation.
> Some classes will signal trailing characters as a bug, some other
> won't and will simply leave the stream positioned after the valid
> part.
> I propose to change this behaviour uniformly:
> - readFrom: aStream will never fail on trailing chars (hey, it's a
> stream, it's up to sender to interpret the tail)
> - readFromString: aString will always forbid trailing char (it's not a
> stream, so this garbage is most probably an error and cannot be
> ignored silently)
> 
> What do you think ?

This sounds right to me. I suspect that it might be difficult to
do this without breaking some external packages, but it does seem
like the right thing to do.

Dave




More information about the Squeak-dev mailing list