2011/9/11 Levente Uzonyi <leves at elte.hu>:
> On Sun, 11 Sep 2011, Frank Shearar wrote:
>
>> Any chance of getting a reject/OK on the below?
>>
>> Bert had an issue with the original - Monticello-fbs.467 - which 468
>> addresses (namely, a misleading variable name).
>
> I tried evaluating
>
>    Installer ss
>        project: 'Zippers';
>        install: 'Zippers-fbs.999'.
>
> after merging Monticello-fbs.468, but I got a different error than expected:
> "attempt to index non-existent element in an ordered collection".

Ah, but did you have a network connection when you ran the test? The
bug only occurs when you cannot reach the remote repository, hence the
"offline" in the bug description.

Monticello _also_ fails to give a proper error message when it can't
find a version - you'd ideally have been told "this repository does
not contain 'Zippers-fbs.999'" - but that's out of scope for this bug
fix.

And thanks for trying it out!

frank

> Levente
>
>>
>> frank
>>
>> On 9 June 2011 20:10,  <commits at source.squeak.org> wrote:
>>>
>>> A new version of Monticello was added to project The Inbox:
>>> http://source.squeak.org/inbox/Monticello-fbs.468.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Monticello-fbs.468
>>> Author: fbs
>>> Time: 9 June 2011, 8:10:14.668 pm
>>> UUID: adb87d13-5e2c-4032-b404-f26c78e21f4a
>>> Ancestors: Monticello-ul.466
>>>
>>> Better error messages for off-line work:
>>> * If you can't find a base "full version", say so
>>> * If you Give Up on trying to resolve a name, report the actual failure
>>> rather than trying to access a socket anyway, and throwing a primitive
>>> failed error.
>>>
>>> =============== Diff against Monticello-ul.466 ===============
>>>
>>> Item was changed:
>>>  ----- Method: MCDiffyVersion>>baseSnapshot (in category 'as yet
>>> unclassified') -----
>>>  baseSnapshot
>>> +       | baseVersion |
>>> +       baseVersion := self workingCopy repositoryGroup versionWithInfo:
>>> base.
>>> +       baseVersion ifNil: [Error signal: 'Missing snapshot: ', self
>>> baseInfo name].
>>> +       ^ baseVersion snapshot!
>>> -       ^ (self workingCopy repositoryGroup versionWithInfo: base)
>>> snapshot!
>>>
>>> Item was changed:
>>>  ----- Method: MCHttpRepository>>allFileNames (in category 'required')
>>> -----
>>>  allFileNames
>>>        | index |
>>> +       [self displayProgress: 'Updating ', self description during:[
>>> -       self displayProgress: 'Updating ', self description during:[
>>>                index := HTTPSocket httpGet: self
>>> locationWithTrailingSlash, '?C=M;O=D' args: nil user: self user passwd: self
>>> password.
>>> +       ]] on: NetworkError do: [ :e | self error: 'Could not access ',
>>> location, '(', e className, ')'].
>>> -       ].
>>>        index isString ifTrue: [self error: 'Could not access ',
>>> location].
>>>        ^ self parseFileNamesFromStream: index  !
>>>
>>>
>>>
>>
>
>
>
>