[squeak-dev] The Inbox: Tests-cwp.158.mcz

Frank Shearar frank.shearar at gmail.com
Tue Aug 14 12:09:03 UTC 2012


On 14 August 2012 07:27,  <commits at source.squeak.org> wrote:
> A new version of Tests was added to project The Inbox:
> http://source.squeak.org/inbox/Tests-cwp.158.mcz
>
> ==================== Summary ====================
>
> Name: Tests-cwp.158
> Author: cwp
> Time: 13 August 2012, 11:27:52.385 pm
> UUID: 815626bc-7a56-4869-961d-f81880b4a668
> Ancestors: Tests-cwp.157
>
> Renamed the existing tokenish tests, and added tests for selector precedence in the presence of underscores.
>
> =============== Diff against Tests-cwp.157 ===============

> Item was removed:
> - ----- Method: UnderscoreSelectorsTest>>testPrefFalse (in category 'as yet unclassified') -----
> - testPrefFalse
> -       self pref: false during: [self deny: $_ tokenish].!
>
> Item was removed:
> - ----- Method: UnderscoreSelectorsTest>>testPrefTrue (in category 'as yet unclassified') -----
> - testPrefTrue
> -       self pref: true during: [self assert: $_ tokenish].!
>
> Item was added:
> + ----- Method: UnderscoreSelectorsTest>>testTokenishFalse (in category 'tests') -----
> + testTokenishFalse
> +       self pref: false during: [self deny: $_ tokenish].!
>
> Item was added:
> + ----- Method: UnderscoreSelectorsTest>>testTokenishTrue (in category 'tests') -----
> + testTokenishTrue
> +       self pref: true during: [self assert: $_ tokenish].!

Why both testPrefFalse and testTokenishFalse (and both testPrefTrue
and testTokenishTrue) if they both do the same thing?
(testPref(True|False) are in the image now, so unless there's good
reason, I don't see why we can't just remove testTokenish(True|False)
from the above.

Nit: I'd like testPref(True|False) categorised.

Otherwise, +1 from me.

frank


More information about the Squeak-dev mailing list