On 20 December 2012 20:03, Colin Putney <colin at wiresong.com> wrote:
>
>
>
> On Thu, Dec 20, 2012 at 6:05 AM, Frank Shearar <frank.shearar at gmail.com>
> wrote:
>>
>> * http://ftp.squeak.org/4.4/Squeak4.4-12320.tgz
>> * http://ftp.squeak.org/4.4/Squeak4.4-12320.zip
>>
>> This should fix the MC failing tests.
>
>
> This doesn't solve the dirty package problem though
> (http://lists.squeakfoundation.org/pipermail/squeak-dev/2012-December/167052.html).
>
> I ran the following doIt in the above image:
>
>
> | trunk dirty |
> trunk := MCRepositoryGroup default repositories detect:
> [:ea | ea description = 'http://source.squeak.org/trunk'].
>
> dirty := Dictionary new.
> MCWorkingCopy allManagers collect:
> [:ea || changes |
> changes := ea changesRelativeToRepository: trunk.
> changes isEmpty ifFalse:
> [dirty at: ea put: changes]].
> ^ dirty
>
> It takes a while, but it gives the following list of dirty packages:
>
> Collections
> FlexibleVocabularies
> Graphics
> Multilingual
> SMLoader
> ToolBuilder-Kernel
>
> Some of these are harmless, but we shouldn't ship the image without fixing
> at least Collections and ToolBuilder-Kernel.

I can confirm your list. How do we clean these though? For instance,
if I manually remove our old friend WeakRegistry class >>
#migrateOldRegistries I can't save my change because MC rightly thinks
there's no difference between my (new, modified) code and trunk?

Is it completely crazy to - in this case at least - just remove the
method in a do-it and then make sure the package isn't dirty by
verifying with trunk?

WeakRegistry removeSelector: #migrateOldRegistries.
"Some as yet undecided way of forcing a dirty/clean check"

frank

> Colin
>
>
>