[squeak-dev] The Trunk: Morphic-nice.611.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Feb 22 01:58:59 UTC 2012

Nicolas Cellier uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-nice.611
Author: nice
Time: 22 February 2012, 2:57:33.901 am
UUID: 090dee16-7401-427a-8e8f-c40c375793a1
Ancestors: Morphic-cmm.610

Avoid the compiler notification offset to be doubled when evaluating a sub-selection in a TextEditor.


In Squeak, the notification offset is already taken into account in the source Stream because of
	"Answer a ReadStream on the text in the paragraph that is currently  selected."
		on: paragraph string
		from: self startIndex
		to: self stopIndex - 1

So it is not necessary to add the self startIndex offset one more time in TextEditor>>notify:at:in:

This might differ from Cuis solution.

=============== Diff against Morphic-cmm.610 ===============

Item was changed:
  ----- Method: TextEditor>>notify:at:in: (in category 'new selection') -----
  notify: aString at: anInteger in: aStream 
  	"The compilation of text failed. The syntax error is noted as the argument, 
  	aString. Insert it in the text at starting character position anInteger."
+ 	self insertAndSelect: aString at: (anInteger max: 1)!
- 	| pos |
- 	pos := self selectionInterval notEmpty
- 		ifTrue: [
- 			self startIndex + anInteger - 1 ]
- 		ifFalse: [anInteger].
- 	self insertAndSelect: aString at: (pos max: 1)!

More information about the Squeak-dev mailing list