[squeak-dev] Re: TextMorphEditor

David T. Lewis lewis at mail.msen.com
Thu Jan 12 23:45:45 UTC 2012


On Thu, Jan 12, 2012 at 09:55:31AM -0800, Eliot Miranda wrote:
> On Wed, Jan 11, 2012 at 5:02 PM, David T. Lewis <lewis at mail.msen.com> wrote:
> 
> > On Wed, Jan 11, 2012 at 01:24:50PM -0800, Eliot Miranda wrote:
> > > On Wed, Jan 11, 2012 at 1:06 PM, Andreas Raab <andreas.raab at gmx.de>
> > wrote:
> > >
> > > > On 1/11/2012 21:35, David T. Lewis wrote:
> > > >
> > > >> On Wed, Jan 11, 2012 at 12:23:46PM -0800, Eliot Miranda wrote:
> > > >>
> > > >>> Hi All,
> > > >>>
> > > >>>
> > > >>>     I've noticed that TextMorphEditor in Morphic-Text Support
> > inherits
> > > >>> from
> > > >>> ParagraphEditor in ST80-Controllers.  ST80-Controllers is removed by
> > > >>> unloadAllKnownPackages and so this creates an orphan (in this case a
> > > >>> subclass of an obsolete class). In the base image TextMorphEditor is
> > used
> > > >>> only within ParagraphEditor.  Would anyone object if I
> > > >>> moved TextMorphEditor to e.g. ST80-MorphicOrphans or somewhere else
> > in
> > > >>> ST80, or ...?
> > > >>> --
> > > >>> best,
> > > >>> Eliot
> > > >>>
> > > >>
> > > >> Hmm... removing MVC should not be leaving anything unreferenced, and
> > > >> I'm pretty sure that this worked cleanly a year or so ago. I can't
> > > >> check it right now, but I wonder if some some regression has crept
> > > >> back in? Or maybe I just missed something in making MVC unloadable
> > > >> and reloadable.
> > > >>
> > > >
> > > > We switched this over to the Cuis editor hierarchy. TextMorphEditor
> > should
> > > > not be used any longer.
> > > >
> > >
> > > OK; I nuked it.  ParagraphEditor only references it by name, so ST80
> > > doesn't need to be changed.
> >
> > TextMorphEditor is used in the Connectors package, and the Connectors
> > package needs to be loadable in various flavors of Squeak image. There
> > is also a dependency in package MVC for ParagraphEditor>>changeEmphasis:
> > that should be tidied up when TextMorphEditor is removed.
> >
> 
> Then TextMorphEditor needs to be reimplemented in terms of the Cuis editors
> no?

Either that or update Connectors to new the new Cuis based editors if
present, otherwise fall back on TextMorphEditor when used in older images.
If Connectors is the only significant package that is affected, then it
would be preferable to do an update in Connectors. I cannot say if other
packages are affected, I only noticed the Connectors dependency because
that is one that I keep loaded in my working image.

Dave




More information about the Squeak-dev mailing list