On Tue, 24 Jul 2012, Frank Shearar wrote:

> On 20 July 2012 09:46,  <commits at source.squeak.org> wrote:
>> Frank Shearar uploaded a new version of Tools to project The Inbox:
>> http://source.squeak.org/inbox/Tools-fbs.416.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tools-fbs.416
>> Author: fbs
>> Time: 20 July 2012, 9:46:02.222 am
>> UUID: 8ef08c2d-bca9-45ca-9d43-7c2bff45af1d
>> Ancestors: Tools-cmm.414
>>
>> Fix for Mantis issue 7699: deleting a system category causes a jarring leap to the top of the category list.
>>
>> =============== Diff against Tools-cmm.414 ===============
>>
>> Item was changed:
>>   ----- Method: Browser>>removeSystemCategory (in category 'system category functions') -----
>>   removeSystemCategory
>>         "If a class category is selected, create a Confirmer so the user can
>>         verify that the currently selected class category and all of its classes
>>         should be removed from the system. If so, remove it."
>>
>>         self hasSystemCategorySelected ifFalse: [^ self].
>>         self okToChange ifFalse: [^ self].
>>         (self classList size = 0
>>                 or: [self confirm: 'Are you sure you want to
>>   remove this system category
>>   and all its classes?'])
>>                 ifTrue:
>> +               [| nextSelectedCat |
>> +               nextSelectedCat := self systemCategoryList before: self selectedSystemCategory ifAbsent: [nil].
>> +               systemOrganizer removeSystemCategory: self selectedSystemCategory.
>> +               self selectSystemCategory: nextSelectedCat.
>> -               [systemOrganizer removeSystemCategory: self selectedSystemCategory.
>> -               self selectSystemCategory: nil.
>>                 self changed: #systemCategoryList]!
>
> This is how I'd like to write the MessageSet change... eventually. Any
> objections to this change?

Looks okay to me. I usually interpret no respone as "okay, push it" in 
most cases.


Levente

>
> frank
>
>