[squeak-dev] The Inbox: Kernel-fbs.695.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Thu Jun 7 21:45:32 UTC 2012


I think the server shows the diff versus latest ancestor present in
trunk, so this discipline is not strictly necessary...
Though it also reduces ancestor meta-data weight which cannot be bad.

Nicolas

2012/6/7 Frank Shearar <frank.shearar at gmail.com>:
> As you wish!
>
> I've deliberately kept the parents of these commits as the latest
> trunk version, so it's easier to see what's going on. That works, at
> least, for these tiny guys.
>
> frank
>
> On 7 June 2012 21:15, Nicolas Cellier
> <nicolas.cellier.aka.nice at gmail.com> wrote:
>> You could also change
>> evaluateResolver: resolverBlock
>>        resolverBlock cull: value
>>
>> Nicolas
>>
>>
>> 2012/6/7  <commits at source.squeak.org>:
>>> A new version of Kernel was added to project The Inbox:
>>> http://source.squeak.org/inbox/Kernel-fbs.695.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Kernel-fbs.695
>>> Author: fbs
>>> Time: 7 June 2012, 9:05:22.987 pm
>>> UUID: 0b1b9159-c4b6-4c3b-934c-c19d87b758b2
>>> Ancestors: Kernel-nice.693
>>>
>>> * Use the canonical Array empty rather than #();
>>> * the instvar's initialised to an Array anyway so #ifNotNil: is a no-op.
>>>
>>> =============== Diff against Kernel-nice.693 ===============
>>>
>>> Item was changed:
>>>  ----- Method: Promise>>initialize (in category 'initialize') -----
>>>  initialize
>>>        isResolved := false.
>>> +       resolvers := Array empty.
>>> -       resolvers := #().
>>>        mutex := Mutex new.!
>>>
>>> Item was changed:
>>>  ----- Method: Promise>>resolveWith: (in category 'resolving') -----
>>>  resolveWith: arg
>>>        "Resolve this promise"
>>>        mutex critical: [
>>>                isResolved ifTrue: [self error: 'Promise was already resolved'].
>>>                value := arg.
>>>                isResolved := true.
>>> +               resolvers do: [:r | self evaluateResolver: r].
>>> -               resolvers ifNotNil: [resolvers do: [:r | self evaluateResolver: r]].
>>>        ].!
>>>
>>>
>>
>


More information about the Squeak-dev mailing list