[squeak-dev] The Trunk: Tools-bf.397.mcz

Eliot Miranda eliot.miranda at gmail.com
Thu Mar 22 16:12:34 UTC 2012


re the confusion of copyFrom: (i.e. that it looks to be part of the
copyFrom:to: family) could we please come up with a renaming of copyFrom:,
e.g. copyStateFrom: or copyInstVarsFrom: and start using it so that some
time we may have (c copyFrom: i) = (c copyFrom: i to: c size) ?

On Thu, Mar 22, 2012 at 8:16 AM, <commits at source.squeak.org> wrote:

> Bert Freudenberg uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-bf.397.mcz
>
> ==================== Summary ====================
>
> Name: Tools-bf.397
> Author: bf
> Time: 22 March 2012, 4:15:47.476 pm
> UUID: 01d6b8f6-6a5a-40cb-bafd-c266b07ec665
> Ancestors: Tools-bf.396
>
> Preserve dependents when making new inspector. Otherwise, the new
> inspector becomes unresponsive.
>
> =============== Diff against Tools-bf.396 ===============
>
> Item was changed:
>  ----- Method: Inspector>>inspect: (in category 'initialize-release') -----
>  inspect: anObject
>        "Initialize the receiver so that it is inspecting anObject. There
> is no current selection.
>
>        Normally the receiver will be of the correct class (as defined by
> anObject inspectorClass),
>        because it will have just been created by sedning inspect to
> anObject.   However, the
>        debugger uses two embedded inspectors, which are re-targetted on
> the current receiver
>        each time the stack frame changes.  The left-hand inspector in the
> debugger has its
>        class changed by the code here.  Care should be taken if this
> method is overridden to
>        ensure that the overriding code calls 'super inspect: anObject', or
> otherwise ensures that
>        the class of these embedded inspectors are changed back."
>
>        | c |
>        c := anObject inspectorClass.
>        self class ~= c ifTrue: [
>                self class format = c format
>                        ifTrue: [self primitiveChangeClassTo: c basicNew]
> +                       ifFalse: [self becomeForward: (c basicNew
> copyFrom: self)]].
> -                       ifFalse: [self becomeForward: c basicNew]].
>        "Set 'object' before sending the initialize message, because some
> implementations
>        of initialize (e.g., in DictionaryInspector) require 'object' to be
> non-nil."
>
>        object := anObject.
>        self initialize!
>
>
>


-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20120322/d8ab414b/attachment.htm


More information about the Squeak-dev mailing list