[squeak-dev] The Trunk: Compiler-eem.239.mcz

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Tue Nov 6 12:03:30 UTC 2012


Some kind of Heisenberg principle, you cannot observe a node without
some sort of interaction ;).
We should create a price for the best anti-pattern of the month.
It's invaluable for teaching.

Nicolas

2012/11/6  <commits at source.squeak.org>:
> Eliot Miranda uploaded a new version of Compiler to project The Trunk:
> http://source.squeak.org/trunk/Compiler-eem.239.mcz
>
> ==================== Summary ====================
>
> Name: Compiler-eem.239
> Author: eem
> Time: 5 November 2012, 3:09:13.298 pm
> UUID: 074c58f2-bc92-4c3f-adff-56c47d3884ef
> Ancestors: Compiler-eem.238
>
> Eliminate horrible side-effect in printing whileTrue/whileFalse
> nodes that undid the tranformation to whileTrue:/whileFalse:.
>
> =============== Diff against Compiler-eem.238 ===============
>
> Item was changed:
>   ----- Method: MessageNode>>printWhileOn:indent: (in category 'printing') -----
>   printWhileOn: aStream indent: level
> -
>         self printReceiver: receiver on: aStream indent: level.
> +       self
> +               printKeywords: originalSelector
> +               arguments: originalArguments
> -       (arguments isEmpty not
> -        and: [arguments first isJust: NodeNil]) ifTrue:
> -                       [selector := SelectorNode new
> -                                                       key:
> -                                                                       (selector key == #whileTrue:
> -                                                                               ifTrue: [#whileTrue]
> -                                                                               ifFalse: [#whileFalse])
> -                                                       code: #macro.
> -                       arguments := Array new].
> -       self printKeywords: selector key arguments: arguments
>                 on: aStream indent: level!
>
>


More information about the Squeak-dev mailing list