[squeak-dev] The Inbox: Kernel-fbs.735.mcz

Tobias Pape Das.Linux at gmx.de
Fri Feb 1 10:47:23 UTC 2013


Am 31.01.2013 um 23:56 schrieb Frank Shearar <frank.shearar at gmail.com>:

> On 31 January 2013 00:16, Chris Cunningham <cunningham.cb at gmail.com> wrote:
>> On Wed, Jan 30, 2013 at 10:50 AM, Frank Shearar <frank.shearar at gmail.com>
>> wrote:
>>> 
>>> On 30 January 2013 18:33,  <commits at source.squeak.org> wrote:
>>> 
>>> <snip>
>>> 
>>> Diffs serve as a helper for reviewers. To that end, the diffs ought to
>>> actually show what changes would be applied to trunk should the change
>>> be accepted. This diff, for instance, shows the removal of
>>> #asMessageSend and the addition of #asMessage, but really the change
>>> applied to trunk will be just the addition of #asMessage.
>>> 
>>> In other words when something undergoes a few rounds of review (and
>>> I'd think this should be the _norm_) the reviewer must reconstruct a
>>> series of diffs to get an idea of how trunk will change.
>>> 
>>> Wouldn't it be better to diff against trunk rather than against the
>>> mcz's ancestor? (*)
>>> 
>>> frank
>> 
>> Yes, it would be better to diff against trunk.  But 'Trunk' isn't a defined
>> state - what you have currently as Trunk isn't what I have currently as
>> trunk - I haven't updated as recently as you have, for instance, so the
>> changes that will be applied if I accepted/updated will be different than if
>> you accept/update.
> 
> No, "trunk" is whatever the trunk repo says.
> 
> Once I figure out how to load the version of ss3 that SqF runs and
> turned it into an SM package (*), I'll submit the patch Bert asked
> for, and we'll have diffs against the trunk repo.
> 

Hello Frank. 
I just want to make sure that you know that source.squeak.org is 
_not_ running ss3. While I am reguarily “harvesting” features from
the source.squeak.org version into ss3, its not the version running
there :)


best
	-tobas


More information about the Squeak-dev mailing list