[squeak-dev] MessageTally bug or VM parameter bug?

Frank Shearar frank.shearar at gmail.com
Thu Jan 17 20:49:48 UTC 2013


I ran a MessageTally and was told that False doesn't understand #-.
This, it turns out, was because MessageTally >> #computeGCStats
assumes that all VM parameters are Number-like. Changing the method to
this:

computeGCStats
	"Compute the deltas in the GC stats.  Serves for reporting,
hibernating and unhibernating."
	SmalltalkImage current getVMParameters keysAndValuesDo:
		[ :idx :gcVal |
		gcVal isNumber ifTrue: [ "This is the new line"
			gcVal ifNotNil: [gcStats at: idx put: (gcVal - (gcStats at: idx))]]]

lets the MessageTally run to completion. Now this might be because I'm
running a Cog r.2672 and a 4.3 image. I don't know.

My question is this: should SmalltalkImage current getVMParameters
keys be a collection of Numbers? Or should MessageTally defend against
things not being numbers? Or have I just stumbled across a bad
image/VM combination?

frank


More information about the Squeak-dev mailing list