[squeak-dev] MessageTally bug or VM parameter bug?

Eliot Miranda eliot.miranda at gmail.com
Thu Jan 17 21:14:05 UTC 2013


On Thu, Jan 17, 2013 at 12:49 PM, Frank Shearar <frank.shearar at gmail.com>wrote:

> I ran a MessageTally and was told that False doesn't understand #-.
> This, it turns out, was because MessageTally >> #computeGCStats
> assumes that all VM parameters are Number-like. Changing the method to
> this:
>
> computeGCStats
>         "Compute the deltas in the GC stats.  Serves for reporting,
> hibernating and unhibernating."
>         SmalltalkImage current getVMParameters keysAndValuesDo:
>                 [ :idx :gcVal |
>                 gcVal isNumber ifTrue: [ "This is the new line"
>                         gcVal ifNotNil: [gcStats at: idx put: (gcVal -
> (gcStats at: idx))]]]
>
> lets the MessageTally run to completion. Now this might be because I'm
> running a Cog r.2672 and a 4.3 image. I don't know.
>
> My question is this: should SmalltalkImage current getVMParameters
> keys be a collection of Numbers? Or should MessageTally defend against
> things not being numbers? Or have I just stumbled across a bad
> image/VM combination?
>

Both of the last two.  This was fixed in 4.4 a few weeks ago.
The VM change was to answer a boolean for parameter 65, this being whether
the VM supports multiple bytecode sets or not.
-- 
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130117/80933b9c/attachment.htm


More information about the Squeak-dev mailing list