[squeak-dev] Character>to: was changed and breaks ObjectsTool

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Thu Jul 18 16:00:18 UTC 2013


Yes it should,
it was a bit shorter, but rationale was told in Collection-nice.518
http://lists.squeakfoundation.org/pipermail/squeak-dev/2013-May/170832.html


2013/7/18 Chris Muller <asqueaker at gmail.com>

> The "why" of any change like this should be documented by its
> MCVersionInfo.
>
> On Wed, Jul 17, 2013 at 10:56 PM, tim Rowledge <tim at rowledge.org> wrote:
> >
> > On 17-07-2013, at 7:18 PM, Levente Uzonyi <leves at elte.hu> wrote:
> >
> >> On Wed, 17 Jul 2013, tim Rowledge wrote:
> >>
> >>> Not long ago Character>to: was changed to return a String instead of
> an Array. That broke ObjectsTool>alphabeticTabs
> >>>
> >>> Either we need to fix alphabeticTabs to re-convert the String to a
> collection, or rescind the change to Character>to:. It would help if the
> rationale for that change were known.
> >>
> >> The fix is easy, just replace the line causing the bug with this:
> >>
> >>       tabLabels := ($a to: $z) collect: [:ch | ch asString] as:
> OrderedCollection.
> >>
> >> I can't commit now, so please do it.
> >
> > I had already sent a fix like that to Frank - since he's tearing up the
> system right now and I'm a bit occupied with Scratch modernisation - but
> I'm not convinced it is better than making $a to: $z go back to returning
> an Array. I *know* a String is kinda-sorta an array of characters - but I
> want to be assured that the change didn't bugger up any other methods as a
> side-effect. Why was it done? What efforts to ensure it didn't screw things
> were made?
> >
> >
> > tim
> > --
> > tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> > Strange OpCodes: YOGA: Exit Finite-State Mode
> >
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130718/102d824e/attachment.htm


More information about the Squeak-dev mailing list