[squeak-dev] Character>to: was changed and breaks ObjectsTool

David T. Lewis lewis at mail.msen.com
Fri Jul 19 23:47:31 UTC 2013


On Thu, Jul 18, 2013 at 08:37:06AM -0500, Chris Muller wrote:
> The "why" of any change like this should be documented by its MCVersionInfo.

Ok, I'll bite. I'm looking at Character>>to: in a browser. I can find the
version history, which gives a useful versions browser. And the versions
browser provides "find original change set" in its menu. Very cool, although
it does not seem to actually work. But never mind that, I'm sure that it
used to work once upon a time, and it's a great idea so I like it.

I don't see anything at all that takes me to the MCVersionInfo corresponding
to a version in the versions browser. Am I missing something?

Dave


> 
> On Wed, Jul 17, 2013 at 10:56 PM, tim Rowledge <tim at rowledge.org> wrote:
> >
> > On 17-07-2013, at 7:18 PM, Levente Uzonyi <leves at elte.hu> wrote:
> >
> >> On Wed, 17 Jul 2013, tim Rowledge wrote:
> >>
> >>> Not long ago Character>to: was changed to return a String instead of an Array. That broke ObjectsTool>alphabeticTabs
> >>>
> >>> Either we need to fix alphabeticTabs to re-convert the String to a collection, or rescind the change to Character>to:. It would help if the rationale for that change were known.
> >>
> >> The fix is easy, just replace the line causing the bug with this:
> >>
> >>       tabLabels := ($a to: $z) collect: [:ch | ch asString] as: OrderedCollection.
> >>
> >> I can't commit now, so please do it.
> >
> > I had already sent a fix like that to Frank - since he's tearing up the system right now and I'm a bit occupied with Scratch modernisation - but I'm not convinced it is better than making $a to: $z go back to returning an Array. I *know* a String is kinda-sorta an array of characters - but I want to be assured that the change didn't bugger up any other methods as a side-effect. Why was it done? What efforts to ensure it didn't screw things were made?
> >
> >
> > tim
> > --
> > tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> > Strange OpCodes: YOGA: Exit Finite-State Mode
> >
> >
> >


More information about the Squeak-dev mailing list