On 2013-06-01, at 22:20, commits at source.squeak.org wrote:

> Frank Shearar uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-fbs.655.mcz
> 
> ==================== Summary ====================
> 
> Name: Morphic-fbs.655
> Author: fbs
> Time: 1 June 2013, 11:19:58.083 pm
> UUID: b2ebeb75-74c9-4909-b81c-8eb82350599a
> Ancestors: Morphic-fbs.654
> 
> Move MailComposition >> #addAttachment to Morphic-Support because the sole sender of #addAttachment (MailComposition >> #morphicOpen) is in Morphic-Support.
> 
> =============== Diff against Morphic-fbs.653 ===============
> 
> Item was added:
> + ----- Method: MailComposition>>addAttachment (in category '*Morphic-Support') -----
> + addAttachment
> + 	| file fileResult fileName |
> + 	textEditor
> + 		ifNotNil: [self hasUnacceptedEdits ifTrue: [textEditor accept]].
> + 
> + 	(fileResult := StandardFileMenu oldFile)
> + 		ifNotNil: 
> + 			[fileName := fileResult directory fullNameFor: fileResult name.
> + 			file := FileStream readOnlyFileNamed: fileName.
> + 			file ifNotNil:
> + 				[file binary.
> + 				self messageText:
> + 						((MailMessage from: self messageText asString)
> + 							addAttachmentFrom: file withName: fileResult name; text).
> + 				file close]] !



Is that a good enough reason to make this an extension method? Just because the only current sender is an outside package doesn't necessarily mean it belongs to that package, does it? It seems innocuous to me, but it's quite possible I'm overlooking something.

- Bert -