[squeak-dev] Project class >> #makeExistingView:project:projectsToBeDeleted:

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Mon Jun 3 18:27:12 UTC 2013


tell don't ask ;)


2013/6/3 Frank Shearar <frank.shearar at gmail.com>

> I just found this method. It contains this snippet:
>
> Smalltalk isMorphic ifTrue: [
>     proj createViewIfAppropriate.
> ] ifFalse: [
>     ChangeSorter allChangeSets add: proj changeSet.
>     ProjectView openAndEnter: proj.
>     "Note: in MVC we get no further than the above"
> ].
>
> Wouldn't that be better written by implementing
>
> MVCProject >> #createViewIfAppropriate
>     ChangeSorter allChangeSets add: proj changeSet.
>     ProjectView openAndEnter: proj.
>
> and ripping out the #isMorphic call?
>
> frank
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20130603/f20c3042/attachment.htm


More information about the Squeak-dev mailing list