On 22 June 2013 00:37, Chris Muller <asqueaker at gmail.com> wrote:
> This would seem to change the capability that a browser can have the
> same message in the list more than once.

A Brower can't have the same message in the list more than once - that
would imply a duplicate system category, or two classes with the same
name within a message category, or...

> Is this to support some functionality?  Or just a "clean up"?

It's cleanup because I made Browser use Symbols instead of indices a
year or two ago. The use case was that Browsers would lose your place
when things happened, because an integer index has no semantic
meaning. Inserting a new item into the list, or removing same, caused
the Browser to behave oddly.

I can't recall offhand what I did in the MessageSet group of browsers,
but I'm pretty sure they no longer use indices either.

frank

> On Fri, Jun 14, 2013 at 3:55 PM,  <commits at source.squeak.org> wrote:
>> Eliot Miranda uploaded a new version of Tools to project The Trunk:
>> http://source.squeak.org/trunk/Tools-eem.471.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tools-eem.471
>> Author: eem
>> Time: 14 June 2013, 1:55:19.221 pm
>> UUID: f14f2736-5c49-41d5-ab67-fddee7e61176
>> Ancestors: Tools-fbs.470
>>
>> Update multi-window browser switching now browsers no
>> longer use integer indices, and instead use the relevant
>> symbols themselves.
>>
>> =============== Diff against Tools-fbs.470 ===============
>>
>> Item was changed:
>>   ----- Method: Browser>>restoreToCategory:className:protocol:selector:mode:meta: (in category 'multi-window support') -----
>>   restoreToCategory: category className: className protocol: protocol selector: selector mode: editMode meta: metaBool
>> +       selectedSystemCategory := nil. "forces recomputation in selectSystemCategory:"
>>         self selectSystemCategory: category.
>> +       self selectClassNamed: className.
>> -       self classListIndex: (self classListIndexOf: className).
>>         self metaClassIndicated: metaBool.
>> +       self selectMessageCategoryNamed: protocol.
>> +       self selectMessageNamed: selector.
>> -       self messageCategoryListIndex: (self messageCategoryList indexOf: protocol).
>> -       self messageListIndex: (self messageList indexOf: selector).
>>         editSelection := editMode.
>>         self
>>                 contentsChanged;
>>                 decorateButtons!
>>
>>
>