[squeak-dev] The Trunk: ToolBuilder-Kernel-fbs.58.mcz
Frank Shearar
frank.shearar at gmail.com
Fri Nov 1 15:43:24 UTC 2013
On 1 November 2013 15:31, Levente Uzonyi <leves at elte.hu> wrote:
> On Fri, 1 Nov 2013, Frank Shearar wrote:
>
>> On 1 November 2013 13:02, Levente Uzonyi <leves at elte.hu> wrote:
>>>
>>> On Fri, 1 Nov 2013, Nicolas Cellier wrote:
>>>
>>>> Please, also remove the preamble and postscript in Graphics, it was a
>>>> one
>>>> shot workaround.
>>>
>>>
>>>
>>> Those won't be evaluated, unless they have changed.
>>
>>
>> But it's a good practice to follow, because otherwise someone else
>> hacking on Graphics that needs a preamble doesn't have to wonder about
>> whether or not the existing code's still needed.
>
>
> When you change these scripts, you should remove the previous stuff
> altogether, since these scripts are always intended to be run once.
I thought that's what I was saying? Graphics' preamble now just has a
comment saying what it's for (to run stuff before Graphics loads). Or
do you mean deleting the preamble entirely?
frank
> Levente
>
>
>>
>> frank
>>
>>> Levente
>>>
>>>
>>>>
>>>>
>>>> 2013/11/1 Frank Shearar <frank.shearar at gmail.com>
>>>> The trick is to write the mail and then go to bed. In the morning,
>>>> someone (some people) will have solved your problems! I'll publish
>>>> two separate mcms.
>>>>
>>>> Thanks!
>>>>
>>>> frank
>>>>
>>>> On 01 Nov 2013, at 0:44, Levente Uzonyi <leves at elte.hu> wrote:
>>>>
>>>> > I should read all mails before I start replying. :)
>>>> >
>>>> >
>>>> > Levente
>>>> >
>>>> > On Thu, 31 Oct 2013, Nicolas Cellier wrote:
>>>> >
>>>> >> Yes, but the other way is to commit a new mcm with the new
>>>> UIManagers, but without Graphics changes.
>>>> >> You then do not need to mess with load order... Unless I missed
>>>> something.
>>>> >> 2013/10/31 Frank Shearar <frank.shearar at gmail.com>
>>>> >> On 31 October 2013 22:19, <commits at source.squeak.org>
>>>> wrote:
>>>> >> > Frank Shearar uploaded a new version of ToolBuilder-Kernel
>>>> to project The Trunk:
>>>> >> >
>>>> http://source.squeak.org/trunk/ToolBuilder-Kernel-fbs.58.mcz
>>>> >> >
>>>> >> > ==================== Summary ====================
>>>> >> >
>>>> >> > Name: ToolBuilder-Kernel-fbs.58
>>>> >> > Author: fbs
>>>> >> > Time: 31 October 2013, 10:18:57.495 pm
>>>> >> > UUID: f4158a78-a770-0548-a26b-a9cfd0ea9beb
>>>> >> > Ancestors: ToolBuilder-Kernel-dtl.57
>>>> >> >
>>>> >> > Step 1 of moving control over display depth to the
>>>> UIManagers.
>>>> >> >
>>>> >> > =============== Diff against ToolBuilder-Kernel-dtl.57
>>>> ===============
>>>> >> So I think the next step is to make the DisplayScreen methods
>>>> forward
>>>> >> entirely to UIManagers. But getting this wrong means bad things.
>>>> So I
>>>> >> thought I'd check first that this will work out:
>>>> >> * make the change
>>>> >> * commit Graphics
>>>> >> * change the update configuration map to load the UIManagers
>>>> before Graphics.
>>>> >> * copy Graphics to trunk
>>>> >> Think it'll work?
>>>> >> frank
>>
>>
>>
>
More information about the Squeak-dev
mailing list
|