On 16 Oct 2013, at 3:25, Chris Muller <asqueaker at gmail.com> wrote:

> The only thing I did to this method was to fix the selector -- there
> was no implementor of #revertLastMethodSubmission on RecentMessages.
> It never got moved/copied from Utilities.

Huh. It wouldn't be the first time I'd missed something. Thanks!

>> I realise I'm the guy who touched this last, but it looks completely
>> wrong. I mean, the new name's an improvement. But we revert the most
>> recent submission, and then say that we reverted the _new_ most recent
>> submission... which was surely the _second_ most recent submission?!
> 
> I don't think so.  A installation of any method, whether by save or
> revert, makes it the most-recent submission, irregardless of its prior
> position / existence in the list.

That's my point. Given submissions in order of a, b, c the most recent is c. We revert that, and then ask what the most recent submission is, to display to the user. But most recent now means b!

frank


>> 453177 that block needs to say
>> 
>>    ifTrue: [ |reverted|
>>        reverted := RecentMessages default mostRecent.
>>        RecentMessages default revertMostRecent.
>>        self cr; show: 'reverted: ', reverted printString.
>>        okToRevert := false]
>> 
>> ?
>> 
>> frank
>> 
>